Add optional custom ctor via voidable sum pattern#111
Closed
JordanMartinez wants to merge 1 commit intopurescript-contrib:mainfrom
JordanMartinez:add-custom-ctor
Closed
Add optional custom ctor via voidable sum pattern#111JordanMartinez wants to merge 1 commit intopurescript-contrib:mainfrom JordanMartinez:add-custom-ctor
JordanMartinez wants to merge 1 commit intopurescript-contrib:mainfrom
JordanMartinez:add-custom-ctor
Conversation
|
@JordanMartinez |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #85, except not quite...
Voiddoesn't have anEqinstance, so neither doesJsonDecodeError'. Thus, the test won't compile. Moreover, I'm not sureVoidshould have an Eq instance. While we could update the test to not use==, will this have implications for the rest of the ecosystem that'd we want?Checklist: