Fix FillDiagonalOffset.grad for complex dtypes#1950
Open
WHOIM1205 wants to merge 1 commit intopymc-devs:mainfrom
Open
Fix FillDiagonalOffset.grad for complex dtypes#1950WHOIM1205 wants to merge 1 commit intopymc-devs:mainfrom
WHOIM1205 wants to merge 1 commit intopymc-devs:mainfrom
Conversation
Signed-off-by: WHOIM1205 <rathourprateek8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Correct gradient length for
FillDiagonalOffsetwith complex inputsBug
FillDiagonalOffset.gradreturned only 2 gradient entries in the complex-dtype early-exit path, even though the Op has 3 inputs (a,val,offset).This caused an opaque
AssertionErrorinside the gradient machinery when users attempted to compute gradients with complex matrices.Fix
Updated the complex branch in
pytensor/tensor/extra_ops.py: