Skip to content

Jules - fix macos/python>=3.13. #4915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julian-smith-artifex-com merged 3 commits into from
Feb 24, 2026
+18 −7
Merged

Jules - fix macos/python>=3.13. #4915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a01de2
tests/conftest.py: add some platform details to any junit .xml file.
julian-smith-artifex-com Feb 23, 2026
af559dc
setup.py: fixed handling of --clean if mupdf is not within pymupdf ch…
julian-smith-artifex-com Feb 24, 2026
7f4526f
setup.py: use latest swig on macos.
julian-smith-artifex-com Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,14 +1218,19 @@ def clean(all_):
ret.append(f'{g_root}/src/build')

path_mupdf, _ = get_mupdf()
ret.append(f'{path_mupdf}/platform/c++')
ret.append(f'{path_mupdf}/platform/python')

# We remove mupdf directories directly with shutil.rmtree() instead of
# returning them to pipcl, because pipcl will deliberately fail if asked to
# remove things that are outside our checkout.
shutil.rmtree(f'{path_mupdf}/platform/c++', ignore_errors=True)
shutil.rmtree(f'{path_mupdf}/platform/python', ignore_errors=True)

if all_:
# Clean mupdf C library.
ret.append(f'{path_mupdf}/build')
ret.append(f'{path_mupdf}/platform/win32')
ret.append(f'{path_mupdf}/platform/win32/Release')
ret.append(f'{path_mupdf}/platform/win32/x64')
shutil.rmtree(f'{path_mupdf}/build', ignore_errors=True)
shutil.rmtree(f'{path_mupdf}/platform/win32', ignore_errors=True)
shutil.rmtree(f'{path_mupdf}/platform/win32/Release', ignore_errors=True)
shutil.rmtree(f'{path_mupdf}/platform/win32/x64', ignore_errors=True)

pipcl.log(f'Returning: {ret=}')
return ret
Expand Down Expand Up @@ -1438,9 +1443,10 @@ def platform_release_tuple():
print(f'OpenBSD: pip install of swig does not build; assuming `pkg_add swig`.')
elif PYMUPDF_SETUP_SWIG:
pass
elif darwin or os.environ.get('PYODIDE_ROOT'):
elif os.environ.get('PYODIDE_ROOT'):
# 2025-10-27: new swig-4.4.0 fails badly at runtime on macos.
# 2025-11-06: similar for pyodide.
# 2026-02-24: Appears to work on macos with swig 4.4.1.
ret.append('swig==4.3.1')
else:
ret.append('swig')
Expand Down
5 changes: 5 additions & 0 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ def install_required_packages():

install_required_packages()


@pytest.fixture(scope="session", autouse=True)
def log_global_env_facts(record_testsuite_property):
record_testsuite_property('platform.python_version()', platform.python_version())

# Need to import pymupdf only after we've installed pymupdf-fonts above,
# because pymupdf imports pymupdf_fonts, and copes with import failure.
import pymupdf
Expand Down