Conversation
In 147467d I didn't realize they were significant.
Turns out regendoc doesn't work with the new `.. tab` changes. Undo the tabification in problematic cases for now. Ideally though, we fix regendoc and revert this.
nicoddemus
approved these changes
Nov 8, 2025
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Bummer. Weird that regendoc is looking into ..tab and ..code-block directives.
Please review the changelog entry for the toml support, I recall it mentioned the doc tabs.
Member
Just pointing out in case you missed it. ☝️ |
Member
Author
|
@nicoddemus I noticed, I added a "(sometimes)" in #13878, because most of the times we don't use it in regendoc so can stay tabbed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #13878. Hopefully we can make regendoc work with nested directives in the future but for now let's unblock the 9.0.0 release.