Fix SQL test module import path in parallel test fixture#352
Merged
shaypal5 merged 2 commits intotesting-improvementsfrom Feb 28, 2026
Merged
Fix SQL test module import path in parallel test fixture#352shaypal5 merged 2 commits intotesting-improvementsfrom
shaypal5 merged 2 commits intotesting-improvementsfrom
Conversation
Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
c8b48fe to
475645a
Compare
Copilot
AI
changed the title
[WIP] Address feedback on parallel testing for faster local testing
Fix SQL test module import path in parallel test fixture
Feb 28, 2026
shaypal5
added a commit
that referenced
this pull request
Mar 1, 2026
* Fix SQL test module path in conftest.py fixture Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com> * Initial plan --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
inject_worker_schema_for_sql_testsfixture intests/conftest.pyreferencedtests.test_sql_core, which doesn't exist — SQL tests live attests/sql_tests/test_sql_core.py. This caused anImportErrorwhen SQL tests ran in parallel via pytest-xdist, breaking schema isolation.Change
tests/conftest.py: Corrected the import andmonkeypatch.setattrtarget fromtests.test_sql_core→tests.sql_tests.test_sql_core🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.