Skip to content

Fix SQL test module import path in parallel test fixture#352

Merged
shaypal5 merged 2 commits intotesting-improvementsfrom
copilot/sub-pr-349-again
Feb 28, 2026
Merged

Fix SQL test module import path in parallel test fixture#352
shaypal5 merged 2 commits intotesting-improvementsfrom
copilot/sub-pr-349-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 28, 2026

The inject_worker_schema_for_sql_tests fixture in tests/conftest.py referenced tests.test_sql_core, which doesn't exist — SQL tests live at tests/sql_tests/test_sql_core.py. This caused an ImportError when SQL tests ran in parallel via pytest-xdist, breaking schema isolation.

Change

  • tests/conftest.py: Corrected the import and monkeypatch.setattr target from tests.test_sql_coretests.sql_tests.test_sql_core
# Before
import tests.test_sql_core
monkeypatch.setattr(tests.test_sql_core, "SQL_CONN_STR", new_url)

# After
import tests.sql_tests.test_sql_core
monkeypatch.setattr(tests.sql_tests.test_sql_core, "SQL_CONN_STR", new_url)

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

@shaypal5 shaypal5 marked this pull request as ready for review February 28, 2026 21:23
@shaypal5 shaypal5 self-requested a review as a code owner February 28, 2026 21:23
Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
@shaypal5 shaypal5 force-pushed the copilot/sub-pr-349-again branch from c8b48fe to 475645a Compare February 28, 2026 21:23
Copilot AI changed the title [WIP] Address feedback on parallel testing for faster local testing Fix SQL test module import path in parallel test fixture Feb 28, 2026
@shaypal5 shaypal5 merged commit f547b78 into testing-improvements Feb 28, 2026
1 check was pending
@shaypal5 shaypal5 deleted the copilot/sub-pr-349-again branch February 28, 2026 21:23
shaypal5 added a commit that referenced this pull request Mar 1, 2026
* Fix SQL test module path in conftest.py fixture

Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>

* Initial plan

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants