Skip to content

Extend isolated_cache_directory fixture to cover maxage-marked tests #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaypal5 merged 2 commits into from
Feb 28, 2026
Merged

Extend isolated_cache_directory fixture to cover maxage-marked tests #354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69af063
Initial plan
Copilot Feb 28, 2026
7baaadf
Extend isolated_cache_directory fixture to cover maxage-marked tests
Copilot Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,11 @@ def worker_id(request):
def isolated_cache_directory(tmp_path, monkeypatch, request, worker_id):
"""Ensure each test gets an isolated cache directory.

This is especially important for pickle tests when running in parallel. Each pytest-xdist worker gets its own cache
directory to avoid conflicts.
This is especially important for pickle and maxage tests when running in parallel. Each pytest-xdist worker gets its
own cache directory to avoid conflicts.

"""
if "pickle" in request.node.keywords:
if "pickle" in request.node.keywords or "maxage" in request.node.keywords:
# Create a unique cache directory for this test
cache_dir = tmp_path / "cachier_cache" if worker_id == "master" else tmp_path / f"cachier_cache_{worker_id}"

Expand Down