Skip to content

Fix test_bad_cache_file and test_delete_cache_file failures in serial mode #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix test_bad_cache_file and test_delete_cache_file failures in serial mode #356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37d89a6
Initial plan
Copilot Feb 28, 2026
ba95d97
Fix failing tests: only apply cache dir isolation in parallel test mode
Copilot Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,11 @@ def isolated_cache_directory(tmp_path, monkeypatch, request, worker_id):
own cache directory to avoid conflicts.

"""
if "pickle" in request.node.keywords or "maxage" in request.node.keywords:
# Create a unique cache directory for this test
cache_dir = tmp_path / "cachier_cache" if worker_id == "master" else tmp_path / f"cachier_cache_{worker_id}"
if worker_id != "master" and (
"pickle" in request.node.keywords or "maxage" in request.node.keywords
):
# Create a unique cache directory for this worker
cache_dir = tmp_path / f"cachier_cache_{worker_id}"

cache_dir.mkdir(exist_ok=True, parents=True)

Expand Down