Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14810fef55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Sorry I didn't get to this before, I was away. I'm not a fan of the UI, "core resources" are not explained anywhere, and the double progress bar is quite odd. I also don't think we should sort by core, we end up with Russian at the top and Spanish below. |
|
Thanks for the feedback.
Fair point, I will fix it in a follow-up. I think of a sentence at the bottom.
What would you prefer as an alternative? Tracking only core in progress bar and converting overall progress to text only? That's the approach of the React dashboard.
On the other hand this sorting may motivate teams to keep the core up to date, which should be beneficial for readers. Probably we should get back to the topic of the sorting switching, this would partially address this. |
Closes #140.
Is word overall or total better for the overall progress?
📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/162/merge/