Pick the deepest error among the most relevant ones in each separate subschema#1300
Open
ilia1243 wants to merge 2 commits intopython-jsonschema:mainfrom
Open
Pick the deepest error among the most relevant ones in each separate subschema#1300ilia1243 wants to merge 2 commits intopython-jsonschema:mainfrom
ilia1243 wants to merge 2 commits intopython-jsonschema:mainfrom
Conversation
…subschema Improves `best_match` in the presence of `anyOf` / `oneOf`. Calculate the most relevant error in each separate subschema and choose the deepest one. In particular for `anyOf` / `oneOf` keywords with the only subschema, the best error is resolved as if the subschema was not enclosed by these keywords. Revert main code changes in commit b20234e preserving the tests.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves
best_matchin the presence ofanyOf/oneOf. Calculate the most relevant error in each separate subschema and choose the deepest one.In particular, for
anyOf/oneOfkeywords with the only subschema, the best error is resolved as if the subschema was not enclosed by these keywords.To reproduce:
Revert main code changes in commit b20234e preserving the tests.
Closes: #1257
📚 Documentation preview 📚: https://python-jsonschema--1300.org.readthedocs.build/en/1300/