Open
Conversation
radarhere
reviewed
Feb 8, 2026
Member
|
I've created fjhenigman#1 with some suggestions. |
Remove temporary buffer
Author
|
thanks, I merged those in. |
radarhere
approved these changes
Feb 13, 2026
Updated documentation
Author
|
Sorry for not knowing how this works... |
Member
|
No problem. No, you don't need to do anything. As far as I'm concerned, this is ready to be merged. I'd just like to give one of the other core team members a chance to look it over. Our next release is on April 1, so I don't think it makes a difference when this is merged between now and then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up #9417.
This makes it possible for applications to directly use pcf and bdf font files, instead of going through a conversion step that creates new files.
A little refactoring in
ImageFontso that metrics can be passed directly might make this cleaner.If that makes sense let me know and I can update this PR.