Replace tokenization with tokenize_rt#77
Merged
pquentin merged 3 commits intopython-trio:masterfrom Jul 22, 2022
Merged
Conversation
The standard library module `tokenize` does not round trip, so we had to implement our own tokenization on top of it. However, tokenize_rt does it better, so let's adopt it instead.
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 110 93 -17
Branches 31 26 -5
=========================================
- Hits 110 93 -17
|
sethmlarson
approved these changes
Jul 22, 2022
Contributor
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
Much cleaner, thanks tokenize_rt! Only thing that stood out to me was the version pin but if we have a good reason that's fine for me.
Member
Author
|
Thanks, I removed the pin! Also fixed Windows CI. Can you please take another look? |
Member
Author
|
@asottile Thank you for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard library module
tokenizedoes not round trip, so we had toimplement our own tokenization on top of it. However,
tokenize_rtdoesit better and will enable #75, so let's adopt it instead.