Skip to content

AIPCC-10079: Allow overriding extract_info_from_wheel_file #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Xaenalt wants to merge 1 commit into from
Closed

AIPCC-10079: Allow overriding extract_info_from_wheel_file #912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/fromager/wheels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def _extra_metadata_elfdeps(
return elfinfos


def extract_info_from_wheel_file(
def default_extract_info_from_wheel_file(
req: Requirement, wheel_file: pathlib.Path
) -> tuple[str, Version, BuildTag, frozenset[Tag]]:
# parse_wheel_filename normalizes the dist name, however the dist-info
Expand All @@ -133,6 +133,23 @@ def extract_info_from_wheel_file(
return (dist_name, dist_version, build_tag, wheel_tags)


def extract_info_from_wheel_file(
Copy link
Contributor

@EmilienM EmilienM Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have tests?

Copy link
Author

@Xaenalt Xaenalt Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

req: Requirement, wheel_file: pathlib.Path
) -> tuple[str, Version, BuildTag, frozenset[Tag]]:

wheel_info: tuple[str, Version, BuildTag, frozenset[Tag]] = (
overrides.find_and_invoke(
req.name,
"extract_info_from_wheel_file",
default_extract_info_from_wheel_file,
req=req,
wheel_file=wheel_file,
)
)

return wheel_info


def default_add_extra_metadata_to_wheels(
ctx: context.WorkContext,
req: Requirement,
Expand Down
Loading