Correct the working directory for Emscripten PyRepl tests#625
Merged
encukou merged 3 commits intopython:mainfrom Aug 29, 2025
Merged
Correct the working directory for Emscripten PyRepl tests#625encukou merged 3 commits intopython:mainfrom
encukou merged 3 commits intopython:mainfrom
Conversation
Member
|
Got SSH to prod so I used it. Build https://buildbot.python.org/#/builders/1810/builds/412 used the config. from this PR. Now trying with: --- a/master/custom/factories.py
+++ b/master/custom/factories.py
@@ -1396,7 +1396,7 @@ class EmscriptenBuild(BaseBuild):
Test(
name="PyRepl in Chrome smoke test",
command=[
- "./run_test.sh",
+ "build/Tools/wasm/emscripten/browser_test/run_test.sh",
],
env=compile_environ,
timeout=step_timeout(self.test_timeout), |
Member
|
This one should work. |
Member
|
I assume the Playwright error should be solved by installing deps on the worker: |
Contributor
Author
|
@encukou I've installed the dependencies on the worker; and it looks like we've got a clean build! Thanks for the debugging work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An update to #624 - it looks like the issue was the working directory not including the OOT
buildprefix.