Skip to content

gh-140715: provide support for %F token in strptime; add test for it and %T#140647

Open
jyalim wants to merge 19 commits intopython:mainfrom
jyalim:fix-issue-140644
Open

gh-140715: provide support for %F token in strptime; add test for it and %T#140647
jyalim wants to merge 19 commits intopython:mainfrom
jyalim:fix-issue-140644

Conversation

@jyalim
Copy link

@jyalim jyalim commented Oct 27, 2025

Incrementally builds C99+ datetime support with addition of %F with single line of code. Also adds two tests: one for %F and another for previously supported %T.

Passed all tests (especially changes to new one).

Passed patchcheck.

@bedevere-app
Copy link

bedevere-app bot commented Oct 27, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot
Copy link

python-cla-bot bot commented Oct 27, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@StanFromIreland StanFromIreland changed the title gh-140644: provide support for %F token in strptime; add test for it and %T gh-140715: provide support for %F token in strptime; add test for it and %T Oct 28, 2025
@StanFromIreland
Copy link
Member

I moved this under #140715, can you please update the blurb filename.

jyalim and others added 3 commits October 28, 2025 14:10
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
…kozE0.rst

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@jyalim
Copy link
Author

jyalim commented Oct 28, 2025

I moved this under #140715, can you please update the blurb filename.

I think this is done!

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add them to this tuple:

for directive in ('a', 'A', 'b', 'B', 'c', 'd', 'H', 'I',
'j', 'm', 'M', 'p', 'S',
'U', 'w', 'W', 'x', 'X', 'y', 'Y', 'Z', '%'):

Also, please update the docs removing the (0) note from its row.

The implementation looks good, just a few small things and this will be ready :-)

jyalim and others added 7 commits February 7, 2026 15:24
…kozE0.rst

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Remove extra comments

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
shorten test name

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
shorten test function name

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@jyalim
Copy link
Author

jyalim commented Feb 7, 2026

Thank you, @StanFromIreland, all changes have been made as requested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants