gh-143916: Allow HTAB in wsgiref header values #144118
Open
+28
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Feb 3, 2026
| self._convert_string_type(v) | ||
|
|
||
| def _convert_string_type(self, value): | ||
| def _convert_string_type(self, value, *, name=False): |
Member
There was a problem hiding this comment.
It may be safer to always require the name parameter:
Suggested change
| def _convert_string_type(self, value, *, name=False): | |
| def _convert_string_type(self, value, *, name): |
| """Convert/check value type.""" | ||
| if type(value) is str: | ||
| if _control_chars_re.search(value): | ||
| if (_name_disallowed_re if name else _value_disallowed_re).search(value): |
Member
There was a problem hiding this comment.
nitpick: I would prefer to write this code on two lines for better readability:
Suggested change
| if (_name_disallowed_re if name else _value_disallowed_re).search(value): | |
| regex = (_name_disallowed_re if name else _value_disallowed_re) | |
| if regex.search(value): |
| headers = Headers() | ||
| self.assertRaises(ValueError, headers.__setitem__, f"key{c0}", "val") | ||
| self.assertRaises(ValueError, headers.add_header, f"key{c0}", "val", param="param") | ||
| # HTAB is allowed in values, not names. |
Member
There was a problem hiding this comment.
Suggested change
| # HTAB is allowed in values, not names. | |
| # HTAB (\x09) is allowed in values, not names. |
Member
|
See also PR gh-144371 which rejects control characters in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #143917 we were overzealous,
HTAB(0x09) is allowed in header values but not header names.