gh-139103: Improve namedtuple scaling in free-threaded build #144332
+247
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `_Py_type_getattro_stackref`, a variant of type attribute lookup that returns `_PyStackRef` instead of `PyObject*`. This allows returning deferred references in the free-threaded build, reducing reference count contention when accessing type attributes. This significantly improves scaling of namedtuple instantiation across multiple threads.
vstinner
reviewed
Jan 30, 2026
|
|
||
| // Like PyObject_GetAttr but returns a _PyStackRef. For types, this can | ||
| // return a deferred reference to reduce reference count contention. | ||
| PyAPI_FUNC(_PyStackRef) PyObject_GetAttrStackRef(PyObject *obj, PyObject *name); |
Member
There was a problem hiding this comment.
Can you please rename it to _PyObject_GetAttrStackRef() since it's private?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
_Py_type_getattro_stackref, a variant of type attribute lookup that returns_PyStackRefinstead ofPyObject*. This allows returning deferred references in the free-threaded build, reducing reference count contention when accessing type attributes.This improves scaling of namedtuple instantiation across multiple threads.