gh-140550: allow slots that repeat information from PyModuleDef #144340
+134
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When integrating slots-based module creation is with the inittab, which currently requires PyModuleDef, it would be convenient to reuse the the same slots array for the MethodDef. Allow slots that match what's already present in the PyModuleDef.
25 tasks
Contributor
|
I can confirm that with this PR the PyO3 tests all pass on my |
encukou
commented
Jan 30, 2026
| the module name must be given as :c:member:`PyModuleDef.m_name`. | ||
| If the array contains slots corresponding to :c:type:`PyModuleDef` | ||
| members, the values must match. | ||
| For example, if you use :c:macro:`Py_mod_name` in :c:member:`!m_slots`; |
Member
Author
There was a problem hiding this comment.
Suggested change
| For example, if you use :c:macro:`Py_mod_name` in :c:member:`!m_slots`; | |
| For example, if you use :c:macro:`Py_mod_name` in :c:member:`!m_slots`, |
encukou
commented
Jan 30, 2026
| #undef DEF_SLOT_CASE | ||
| #undef COPY_DEF_SLOT | ||
| #undef COPY_NONDEF_SLOT | ||
| #undef _COPY_COMMON_SLOT |
Member
Author
There was a problem hiding this comment.
Suggested change
| #undef _COPY_COMMON_SLOT | |
| #undef COPY_NONNULL_SLOT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From feedback on the discussion thread:
When integrating slots-based module creation is with the inittab, which currently requires PyModuleDef, it would be convenient to reuse the the same slots array for the MethodDef.
This PR allows slots that match what's already present in the PyModuleDef.
cc @ngoldbaum
📚 Documentation preview 📚: https://cpython-previews--144340.org.readthedocs.build/