Skip to content

gh-62734: Document that open()'s file param becomes name attribute#144455

Closed
kovan wants to merge 2 commits intopython:mainfrom
kovan:gh-62734-open-name-attr
Closed

gh-62734: Document that open()'s file param becomes name attribute#144455
kovan wants to merge 2 commits intopython:mainfrom
kovan:gh-62734-open-name-attr

Conversation

@kovan
Copy link
Contributor

@kovan kovan commented Feb 3, 2026

Summary

  • Clarifies that the value passed as the file parameter to open() is stored in the name attribute of the returned file object

Test plan

  • make check passed
  • Documentation builds correctly

🤖 Generated with Claude Code


📚 Documentation preview 📚: https://cpython-previews--144455.org.readthedocs.build/

Clarify that the value passed as the *file* parameter to open() is
stored in the name attribute of the returned file object.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The name attribute is documented under io.FileIO, not io.IOBase.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take the history of the issue into account before opening a PR. It's not clear that this is the immediate change that we want to make.

More generally, please do not spam us with AI-generated pull requests. Despite what you might think, these are often not helpful contributions and waste maintainer time.

If you're interested in contributing to CPython, I really suggest finding an area that you're interested in, spending the time to thoroughly investigate and triage an issue, and then finally submitting a PR. Otherwise, if you continue to do this, we have no choice but to block you.

@bedevere-app
Copy link

bedevere-app bot commented Feb 4, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@kovan
Copy link
Contributor Author

kovan commented Feb 4, 2026

Block me? haha that's funny. I can just open another GitHub account, eliminate any trace of AI intervention in the commits and PRs and you will have to use your brain to know if the commit is appropiate or not, instead of just preaching.
Not only that, I can do that an infinite number of times, if I need to. Do you realise how of sync you are with the currrent reality?

@ZeroIntensity
Copy link
Member

eliminate any trace of AI intervention in the commits and PRs and you will have to use your brain to know if the commit is appropiate or not, instead of just preaching.

If you can do that, then please do! We only care about AI-generated PRs and issues when they're incorrect, and thus waste maintainer time. CPython is almost entirely maintained by volunteers, so we don't have the time to review and fix AI code in addition to the thousands of PRs that are already on our backlog. If you can put enough effort into fixing AI-generated code that we don't notice, then we'll treat it the same as we do any other contribution. I think you got the impression that we have some vendetta against AI. Our policy allows AI, as long as it's used correctly.

All that said, I'm going to close this. Your comment is in violation of our Code of Conduct, and by the sounds of it, you're also in violation of GitHub's Code of Conduct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes docs Documentation in the Doc dir skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants