gh-136879: Make os.spawn* arg signatures consistent with os.exec*#144458
gh-136879: Make os.spawn* arg signatures consistent with os.exec*#144458kovan wants to merge 1 commit intopython:mainfrom
Conversation
Update os.spawnl, spawnle, spawnlp, and spawnlpe function signatures to show arg0, arg1, ... explicitly, matching the os.execl family of functions for consistency. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
picnixz
left a comment
There was a problem hiding this comment.
Strictly speaking, this is not the signature at runtime. At runtime, the signature is spawnl(mode, path, *args) so the ... part is correct. So I think we should first decide on the issue how we want to document the expanded args. Do we want to explicitly document spawnl(mode, path, arg0, arg1, ...), or spawnl(mode, path, arg0, ...) or simply specify that args must be non-empty with args[0] being the program name by convention? since we did not discuss yet about it, I am closing the PR otherwise it will be kept open for too long.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Summary
os.spawnl,spawnle,spawnlp, andspawnlpefunction signatures to showarg0, arg1, ...explicitlyos.execlfamily of functionsBefore:
spawnl(mode, path, ...)After:
spawnl(mode, path, arg0, arg1, ...)Source verification
Lib/os.pythat both exec* and spawn* use*argsparameterTest plan
make checkpassed🤖 Generated with Claude Code
📚 Documentation preview 📚: https://cpython-previews--144458.org.readthedocs.build/