gh-144148: Update the urllib.parse documentation by serhiy-storchaka · Pull Request #144497 · python/cpython

serhiy-storchaka · 2026-02-05T10:37:39Z

Document urlsplit() as the main parsing function and urlparse() as an obsolete variant.

Issue: Soft deprecate urllib.parse.urlparse() #144148

📚 Documentation preview 📚: https://cpython-previews--144497.org.readthedocs.build/

vstinner · 2026-02-05T11:21:19Z

You should update test_urlparse. Example:

FAIL: test_splituser_deprecation (test.test_urlparse.DeprecationTest.test_splituser_deprecation)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_urlparse.py", line 1931, in test_splituser_deprecation
    self.assertEqual(str(cm.warning),
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
                     'urllib.parse.splituser() is deprecated as of 3.8, '
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                     'use urllib.parse.urlparse() instead')
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'urll[19 chars]) is deprecated as of 3.8, use urllib.parse.urlsplit() instead' != 'urll[19 chars]) is deprecated as of 3.8, use urllib.parse.urlparse() instead'
- urllib.parse.splituser() is deprecated as of 3.8, use urllib.parse.urlsplit() instead
?                                                                        ^^^^
+ urllib.parse.splituser() is deprecated as of 3.8, use urllib.parse.urlparse() instead
?                                                                       +++ ^

Doc/library/urllib.parse.rst

Document urlsplit() as the main parsing function and urlparse() as an obsolete variant.

serhiy-storchaka · 2026-02-05T12:23:37Z

Sorry, I forget to save the last changes before committing. And did not run the tests.

orsenthil

LGTM. It is a clear and the intention comes across correct at the very high level.

serhiy-storchaka · 2026-02-05T14:13:51Z

I force-pushed that change because I had not noticed that Victor already started review.

vstinner

LGTM.

For the 3.14 backport, I'm not sure that it's a good idea to change deprecation messages. Would it be possible to leave deprecation messages unchanged for the backport?

miss-islington-app · 2026-02-05T14:32:22Z

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app · 2026-02-05T14:32:25Z

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 67ddba9aa9c0405c68e691643c4aa75fdbcefe1d 3.14

…GH-144497) Document urlsplit() as the main parsing function and urlparse() as an obsolete variant. (cherry picked from commit 67ddba9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app · 2026-02-05T14:56:25Z

GH-144507 is a backport of this pull request to the 3.14 branch.

…H-144507) Document urlsplit() as the main parsing function and urlparse() as an obsolete variant. (cherry picked from commit 67ddba9)

…GH-144497) (pythonGH-144507) (cherry picked from commit 2fb9cde) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Document urlsplit() as the main parsing function and urlparse() as an obsolete variant. (cherry picked from commit 67ddba9)

…H-144507) (GH-144509) (cherry picked from commit 2fb9cde) Document urlsplit() as the main parsing function and urlparse() as an obsolete variant. (cherry picked from commit 67ddba9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot · 2026-02-05T15:53:19Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 NoGIL Refleaks 3.x (tier-1) has failed when building commit 67ddba9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1610/builds/2857) and take a look at the build logs.
Check if the failure is related to this commit (67ddba9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1610/builds/2857

Failed tests:

test_free_threading

Test leaking resources:

test_free_threading: file descriptors
test_free_threading: memory blocks

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 13, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  14% (1/7)        
remote: Compressing objects:  28% (2/7)        
remote: Compressing objects:  42% (3/7)        
remote: Compressing objects:  57% (4/7)        
remote: Compressing objects:  71% (5/7)        
remote: Compressing objects:  85% (6/7)        
remote: Compressing objects: 100% (7/7)        
remote: Compressing objects: 100% (7/7), done.        
remote: Total 13 (delta 3), reused 3 (delta 3), pack-reused 3 (from 1)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to '67ddba9aa9c0405c68e691643c4aa75fdbcefe1d'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 67ddba9aa9c gh-144148: Update the urllib.parse documentation (GH-144497)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdec found; falling back to pure-Python version for the decimal module

make: *** [Makefile:2524: buildbottest] Error 2

bedevere-bot · 2026-02-05T16:30:43Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Refleaks 3.x (tier-3) has failed when building commit 67ddba9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1641/builds/1648) and take a look at the build logs.
Check if the failure is related to this commit (67ddba9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1641/builds/1648

Failed tests:

test_profiling

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/unittest/case.py", line 666, in run
    with outcome.testPartExecutor(self):
         ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
ResourceWarning: unclosed file <_io.BufferedReader name=8>


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/sample.py", line 59, in __init__
    self.unwinder = self._new_unwinder(native, gc, opcodes, skip_non_matching_threads)
                    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/sample.py", line 74, in _new_unwinder
    return _remote_debugging.RemoteUnwinder(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.pid,
        ^^^^^^^^^
    ...<7 lines>...
        **kwargs
        ^^^^^^^^
    )
    ^
RuntimeError: Failed to find the PyRuntime section in process 3618723 on Linux platform


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_profiling/test_sampling_profiler/test_live_collector_ui.py", line 884, in test_run_failed_script_live
    main()
    ~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 788, in main
    _main()
    ~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 922, in _main
    handler(args)
    ~~~~~~~^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 999, in _handle_run
    _handle_live_run(args)
    ~~~~~~~~~~~~~~~~^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 1133, in _handle_live_run
    sample_live(
    ~~~~~~~~~~~^
        process.pid,
        ^^^^^^^^^^^^
    ...<9 lines>...
        blocking=args.blocking,
        ^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/sample.py", line 487, in sample_live
    profiler = SampleProfiler(
        pid,
    ...<8 lines>...
        blocking=blocking,
    )
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/sample.py", line 61, in __init__
    raise SystemExit(err) from err
SystemExit: Failed to find the PyRuntime section in process 3618723 on Linux platform


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 1110, in _handle_live_run
    process = _run_with_sync(cmd, suppress_output=True)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 279, in _run_with_sync
    _wait_for_ready_signal(sync_sock, process, _SYNC_TIMEOUT_SEC)
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 219, in _wait_for_ready_signal
    _check_process_died(process)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 207, in _check_process_died
    raise RuntimeError(stderr_msg)
RuntimeError: Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
                     "__main__", mod_spec)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/runpy.py", line 87, in _run_code
    exec(code, run_globals)
    ~~~~^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/_sync_coordinator.py", line 256, in <module>
    main()
    ~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/_sync_coordinator.py", line 249, in main
    _execute_script(script_path, script_args, cwd)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/_sync_coordinator.py", line 196, in _execute_script
    exec(code, main_module.__dict__)
    ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/test_python_c0x_aton/tmp8d4kw5na.py", line 1, in <module>
    1/0
    ~^~
ZeroDivisionError: division by zero


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_profiling/test_sampling_profiler/test_live_collector_ui.py", line 884, in test_run_failed_script_live
    main()
    ~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 788, in main
    _main()
    ~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 922, in _main
    handler(args)
    ~~~~~~~^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 999, in _handle_run
    _handle_live_run(args)
    ~~~~~~~~~~~~~~~~^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/cli.py", line 1112, in _handle_live_run
    sys.exit(f"Error: {e}")
    ~~~~~~~~^^^^^^^^^^^^^^^
SystemExit: Error: Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
                     "__main__", mod_spec)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/runpy.py", line 87, in _run_code
    exec(code, run_globals)
    ~~~~^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/_sync_coordinator.py", line 256, in <module>
    main()
    ~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/_sync_coordinator.py", line 249, in main
    _execute_script(script_path, script_args, cwd)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.refleak/build/Lib/profiling/sampling/_sync_coordinator.py", line 196, in _execute_script
    exec(code, main_module.__dict__)
    ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/test_python_c0x_aton/tmp8d4kw5na.py", line 1, in <module>
    1/0
    ~^~
ZeroDivisionError: division by zero

serhiy-storchaka requested review from orsenthil and vstinner February 5, 2026 10:37

serhiy-storchaka requested a review from vsajip as a code owner February 5, 2026 10:37

serhiy-storchaka added the docs Documentation in the Doc dir label Feb 5, 2026

serhiy-storchaka requested review from AA-Turner and FFY00 as code owners February 5, 2026 10:37

serhiy-storchaka added skip news needs backport to 3.14 bugs and security fixes labels Feb 5, 2026

github-project-automation bot added this to Docs PRs Feb 5, 2026

github-project-automation bot moved this to Todo in Docs PRs Feb 5, 2026

bedevere-app bot added the awaiting core review label Feb 5, 2026

bedevere-app bot mentioned this pull request Feb 5, 2026

Soft deprecate urllib.parse.urlparse() #144148

Closed

vstinner reviewed Feb 5, 2026

View reviewed changes

Doc/library/urllib.parse.rst Show resolved Hide resolved

Doc/library/urllib.parse.rst Outdated Show resolved Hide resolved

pythongh-144148: Update the urllib.parse documentation

5f36382

Document urlsplit() as the main parsing function and urlparse() as an obsolete variant.

serhiy-storchaka force-pushed the docs-urllib-parse branch from 34b476b to 5f36382 Compare February 5, 2026 12:19

Fix tests.

e035b2f

orsenthil approved these changes Feb 5, 2026

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels Feb 5, 2026

vstinner approved these changes Feb 5, 2026

View reviewed changes

serhiy-storchaka merged commit 67ddba9 into python:main Feb 5, 2026
50 checks passed

github-project-automation bot moved this from Todo to Done in Docs PRs Feb 5, 2026

bedevere-app bot removed the awaiting merge label Feb 5, 2026

miss-islington-app bot assigned serhiy-storchaka Feb 5, 2026

serhiy-storchaka deleted the docs-urllib-parse branch February 5, 2026 14:32

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Feb 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-144148: Update the urllib.parse documentation#144497

gh-144148: Update the urllib.parse documentation#144497
serhiy-storchaka merged 2 commits intopython:mainfrom
serhiy-storchaka:docs-urllib-parse

serhiy-storchaka commented Feb 5, 2026 •

edited by github-actions bot

Loading

Uh oh!

vstinner commented Feb 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka commented Feb 5, 2026

Uh oh!

orsenthil left a comment

Uh oh!

serhiy-storchaka commented Feb 5, 2026

Uh oh!

vstinner left a comment

Uh oh!

Uh oh!

miss-islington-app bot commented Feb 5, 2026

Uh oh!

miss-islington-app bot commented Feb 5, 2026

Uh oh!

bedevere-app bot commented Feb 5, 2026

Uh oh!

bedevere-bot commented Feb 5, 2026

Uh oh!

bedevere-bot commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

serhiy-storchaka commented Feb 5, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka commented Feb 5, 2026

Uh oh!

orsenthil left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Feb 5, 2026

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Feb 5, 2026

Uh oh!

miss-islington-app bot commented Feb 5, 2026

Uh oh!

bedevere-app bot commented Feb 5, 2026

Uh oh!

bedevere-bot commented Feb 5, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Feb 5, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

serhiy-storchaka commented Feb 5, 2026 •

edited by github-actions bot

Loading

vstinner commented Feb 5, 2026 •

edited

Loading