gh-144618: Don't track ClassVar dataclass members as defaults#144619
Open
johnslavik wants to merge 6 commits intopython:mainfrom
Open
gh-144618: Don't track ClassVar dataclass members as defaults#144619johnslavik wants to merge 6 commits intopython:mainfrom
ClassVar dataclass members as defaults#144619johnslavik wants to merge 6 commits intopython:mainfrom
Conversation
johnslavik
added
needs backport to 3.13
sobolevn
reviewed
Feb 9, 2026
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
What do you think: which parts of 3rd party libs this can potentially affect? Like pydantic validation / etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't added code for cleaning up
ClassVar[Field] = dataclasses.field(default=MISSING)from class members, because this is an incorrect use of the API.Perhaps it should even fail, but that's out of scope of the issue.
__get__on unusedClassVarvalues #144618