[3.13] gh-131261: generate_sbom.py: Exclude the refresh script from SBOM (GH-131359) #144625
+9
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pythonGH-131359) (cherry picked from commit 51d3099)
This was referenced Feb 9, 2026
encukou
changed the title
Member
Author
|
This causes a conflict when backporting the expat update. In #144500, I currently bundle this fix with the expat update, but it seems cleaner to have it as a separate commit. @sethmlarson, does that sound good? |
| - Verify all is okay: | ||
| git diff | ||
| git status | ||
| - Regenerate the sbom file |
Member
There was a problem hiding this comment.
Now that I look at it, this is missing a step, you have to update the version in the sbom file IIRC.
Member
Author
There was a problem hiding this comment.
Could you send a PR for main?
I don't think it even needs to be backported since you only do that on main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 51d3099)