gh-144690: Add C API for trace/profile callback registration#144691
Open
SubbaraoGarlapati wants to merge 1 commit intopython:mainfrom
Open
gh-144690: Add C API for trace/profile callback registration#144691SubbaraoGarlapati wants to merge 1 commit intopython:mainfrom
SubbaraoGarlapati wants to merge 1 commit intopython:mainfrom
Conversation
Comment on lines
+127
to
+132
| typedef enum { | ||
| PyUnstable_EVAL_TRACE_SET = 0, | ||
| PyUnstable_EVAL_TRACE_CLEAR = 1, | ||
| PyUnstable_EVAL_PROFILE_SET = 2, | ||
| PyUnstable_EVAL_PROFILE_CLEAR = 3, | ||
| } PyUnstable_EvalEvent; |
Member
There was a problem hiding this comment.
Public C APIs should go in Include/cpython/..., not Include/internal.
Member
There was a problem hiding this comment.
PyUnstable APIs are not internal; please move this to _testcapi.
Contributor
|
cc @Fidget-Spinner as a JIT expert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a C API for receiving notifications when
sys.settrace()orsys.setprofile()are called, addressing gh-144690.Changes
PyUnstable_SetEvalCallback()andPyUnstable_GetEvalCallback()toregister/retrieve callbacks for trace/profile changes
PyUnstable_EvalEventenum withTRACE_SET,TRACE_CLEAR,PROFILE_SET,PROFILE_CLEARevents_PyEval_SetTrace(),_PyEval_SetTraceAllThreads(),_PyEval_SetProfile(), and_PyEval_SetProfileAllThreads()API