feat: sanitize release names upon submission#2725
Open
JacobCoffee wants to merge 5 commits intomainfrom
Open
Conversation
ewdurbin
reviewed
May 6, 2025
Member
|
@JacobCoffee is there an issue associated with this PR? I mean it makes sense but hard to say if it is "correct" without some documenting reason. |
Member
Author
|
yeah sorry, i thought if i put it in the commit message it would link it |
JacobCoffee
commented
May 6, 2025
Member
Author
|
doh... before i do all the migrations and things, do you think overriding the name on the NameSlugModel and adding the validator is still the best path @ewdurbin? I'm okay with either just wanting to make sure |
JacobCoffee
changed the title
Member
|
This should also allows pre-release names such as:
And we now also have Python install manager releases with names like:
https://www.python.org/admin/downloads/release/ Also this PR has flipped the order of Slug and Name: 
Let's keep Name first like in production: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2724