Skip to content

fix: guard validate_unique against unsaved Release in admin add view #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobCoffee merged 1 commit into from
Feb 23, 2026
Merged

fix: guard validate_unique against unsaved Release in admin add view #2940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/downloads/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ class ReleaseFile(ContentManageable, NameSlugModel):

def validate_unique(self, exclude=None):
"""Ensure only one release file per OS has the download button enabled."""
if self.download_button:
if self.download_button and self.release_id:
qs = ReleaseFile.objects.filter(release=self.release, os=self.os, download_button=True).exclude(pk=self.id)
if qs.count() > 0:
msg = 'Only one Release File per OS can have "Download button" enabled'
Expand Down