Skip to content

Conversation

@donbarbos
Copy link
Contributor

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

core (https://github.com/home-assistant/core)
- homeassistant/components/media_extractor/__init__.py:196: error: TypedDict "_InfoDict" has no key "entries"  [typeddict-item]
+ homeassistant/components/media_extractor/__init__.py:196: error: Argument 1 to "list" has incompatible type "Iterable[_InfoDict] | PagedList"; expected "Iterable[_InfoDict]"  [arg-type]

@donbarbos
Copy link
Contributor Author

Diff from mypy_primer, showing the effect of this PR on open source code:

core (https://github.com/home-assistant/core)
- homeassistant/components/media_extractor/__init__.py:196: error: TypedDict "_InfoDict" has no key "entries"  [typeddict-item]
+ homeassistant/components/media_extractor/__init__.py:196: error: Argument 1 to "list" has incompatible type "Iterable[_InfoDict] | PagedList"; expected "Iterable[_InfoDict]"  [arg-type]

Docstring says:

There must be a key "entries", which is a list, an iterable, or a PagedList object, each element of which is a valid dictionary by this specification.

but unfortunately PagedList doesn't have an __iter__ method to pass it to list()

@srittau srittau merged commit fa659b1 into python:main Jan 30, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants