feat: Add watched folder confirmation when importing files#21
Open
pythoninthegrass wants to merge 2 commits intomainfrom
Open
feat: Add watched folder confirmation when importing files#21pythoninthegrass wants to merge 2 commits intomainfrom
pythoninthegrass wants to merge 2 commits intomainfrom
Conversation
When users drag-and-drop files or use the pill button to add music to the library, they are now prompted to add the parent directories to watched folders. The confirmation modal shows all candidate directories (both immediate and parent levels) with checkboxes, allowing users to select which folders to watch. Features: - Extract parent directories from imported file/folder paths (shows both levels as options) - Classify directories as already-watched or new to avoid redundant additions - Prompt user with confirmation modal before adding to watched folders - Auto-refresh Settings view when watched folders are added via the confirmation flow - Settings and UI stay in sync across the app Fixes critical watcher bug: - Scoped fingerprint queries in watcher.rs to only load tracks within the watched folder being scanned - Previously, adding a watched folder would mark all other library tracks as missing due to full-library fingerprint scope mismatch Tests: - 27 unit tests covering directory extraction, classification, and confirmation flow - All 273 frontend tests passing Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
pythoninthegrass
force-pushed
the
pythoninthegrass/task-259-verify
branch
from
04049e1 to
19c3548
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When users drag-and-drop or use the pill button to add music files to the library, they are now prompted to add the parent directories to watched folders. The confirmation modal presents both immediate and parent directory levels as checkbox options, letting users choose what makes sense for their setup.
Key Changes
watcher.rsthat was marking all non-watched-folder tracks as missing when a new watched folder was addedTests
Related Issue
Implements task 259: Add dragged/pill-button files to watched folders with confirmation