fix(tabs): disabled animated when tabPosition is left/right#505
Open
buqiyuan wants to merge 1 commit intoreact-component:masterfrom
Open
fix(tabs): disabled animated when tabPosition is left/right#505buqiyuan wants to merge 1 commit intoreact-component:masterfrom
buqiyuan wants to merge 1 commit intoreact-component:masterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/tabs/2H9AE6f3VEkQiuxPk967xcqgMPWL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d116b71af68029682db36504af50ec86_671181269581_v_1649488469584584.mp4
实际使用中，当
animated为true的时候，对于tabPosition的四个方向都支持动画过渡效果，但是仅支持横向的过渡效果，当tabPosition为left/right的时候，动画效果应该是纵向过渡的，如果暂时不考虑支持纵向过渡动画，并且要与文档描述相符的话，则当tabPosition为left/right的时候需要禁用动画效果