feat: add test build type for android_build#150
feat: add test build type for android_build#150matinzd wants to merge 1 commit intoreact-native-community:mainfrom
Conversation
|
Could you make an example on why this is needed @matinzd ? |
|
In some react native projects there are different types of flavors are configured for the project based on the needs, but test flavors are not configured or they have different test build type. |
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
but test flavors are not configured or they have different test build type.
I don't have a strong opinion on this. It feels a bit unnecessary to me, but I believe there could be scenarios where this is useful for some.
We can merge this imho. The problem is that I believe the token expired so CircleCI is red at the moment. I'm unsure who can help us here
fotos
force-pushed
the
feat_add_test_build_type
branch
2 times, most recently
from
dc60eab to
ee8a478
Compare
|
@matinzd now that the CI/CD pipeline has been fixed, this needs a rebase. @cortinico if this is still useful feel free to merge. 🚀 |
fotos
force-pushed
the
feat_add_test_build_type
branch
from
ee8a478 to
6645ae5
Compare
I don't have a strong opinion here. We're not using this orb internally and I'll leave the decision to merge to you folks |
fotos
force-pushed
the
feat_add_test_build_type
branch
from
6645ae5 to
f1bd0ba
Compare
fotos
force-pushed
the
feat_add_test_build_type
branch
from
f1bd0ba to
a9e36e6
Compare
3 participants
Add
test_build_typeto build_android job and command.