feat: migrate example tests to @testing-library/react-native#101
Open
mdjastrzebski wants to merge 1 commit intoreact-native-community:mainfrom
Open
Conversation
szymonrybczak
approved these changes
Jan 29, 2025
Collaborator
szymonrybczak
left a comment
szymonrybczak
left a comment
There was a problem hiding this comment.
Nice 👌 Thanks @mdjastrzebski!
cortinico
reviewed
Jan 30, 2025
Member
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Also can you send a PR against https://github.com/facebook/react-native/blob/main/packages/helloworld/package.json as well?
| "@testing-library/react-native": "^13.0.1", | ||
| "@types/jest": "^29.5.13", | ||
| "@types/react": "^19.0.0", | ||
| "@types/react-test-renderer": "^19.0.0", |
Member
There was a problem hiding this comment.
can you remove this and line 34 also?
Author
There was a problem hiding this comment.
Deps on react-test-renderer and @types/ have to stay, as RNTL still uses RTR under the hood. RNTL cannot declare a regular dep on RTR, as user's react and RTR versions have to match. The next major RNTL version will work without RTR.
Contributor
|
Are there any plans to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As React Test Renderer is now deprecated, it make sense to switch example test from RTR to React Native Testing Library which is recommended for RN env.
While RNTL currently uses RTR under the hood, there are works in progress to replace internal RTR usage with alternative supported test renderer. Migrating tests now, direct users to future-proof testing solution.
Replaces #77
Changelog:
GENERAL CHANGED - Migrate example test from deprecated React Test Renderer to React Native Testing Library (@testing-library/react-native).
Test Plan:
Run tests included in the
templatedirectory.