feat: Add support for SF Symbols with customizable font size and weight as segment values on ios#920
Open
iamitkhatkar wants to merge 1 commit intoreact-native-segmented-control:masterfrom
Conversation
…ht as segment values on iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add support for SF Symbols as segment values on iOS (13+), allowing icons like star.fill, list.bullet, etc. alongside text labels
SF Symbol objects support configurable fontSize (default: 19) and weight (ultraLight through black, default: regular)
Add SFSymbol, SFSymbolWeight, and SegmentValue types to both TypeScript and Flow definitions
Update JS bridge to pass SF Symbol objects directly to native without Image.resolveAssetSource
On Android/Web, SF Symbol segments gracefully render as empty (iOS-only feature)
Test Plan