Update documentation to correct the default value of labelVisible#1237
Merged
satya164 merged 1 commit intoreact-navigation:mainfrom Jan 12, 2026
Merged
Conversation
✅ Deploy Preview for react-navigation-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
satya164
force-pushed
the
main
branch
2 times, most recently
from
a2a5d9e to
fcb5e31
Compare
satya164
force-pushed
the
main
branch
5 times, most recently
from
65c6448 to
df873a5
Compare
satya164
force-pushed
the
main
branch
2 times, most recently
from
a739841 to
35a6db3
Compare
satya164
force-pushed
the
main
branch
2 times, most recently
from
7dbaa57 to
9e2af9d
Compare
Member
|
Thanks for the PR. I'm closing this as the original PR has been merged. |
satya164
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is regarding this PR react-navigation/react-navigation#11308. It was recommended to update the documentation, which I never got around to making a PR for.
The documentation currently states that
labelVisibleinHeaderBackButtondefaults totrueon iOS whilefalseon Android, however that is not correct. On both platforms it defaults to false.Regardless of what decision you make on that PR, I figure that it may as well be worth updating the 6.x documentation to state that it does not default to true. I'm not sure how prevalent iOS back buttons without a label are, but it may be best to just leave it be until 7.x if you were going to make the change, since there may be those who don't want the label and are just using the default value as of right now.
I've only updated 6.x since I am not sure what your stance will be going forward on the PR and if you would want to implement that into 7.x.
Thanks