Prefer player default live position for HLS/DASH#2547
Open
NivinCNC wants to merge 1 commit intorecloudstream:masterfrom
Open
Prefer player default live position for HLS/DASH#2547NivinCNC wants to merge 1 commit intorecloudstream:masterfrom
NivinCNC wants to merge 1 commit intorecloudstream:masterfrom
Conversation
When starting a single HLS (M3U8) or DASH stream and no explicit start position was provided (playbackPosition == 0), set playbackPosition to TIME_UNSET so ExoPlayer can choose its default/live position. This prevents forcing a 0 ms start for live/non-playlist streams and lets the player resume at the correct live/default offset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting a single HLS (M3U8) or DASH stream and no explicit start position was provided (playbackPosition == 0), set playbackPosition to TIME_UNSET so ExoPlayer can choose its default/live position. This prevents forcing a 0 ms start for live/non-playlist streams and lets the player resume at the correct live/default offset.
I made this PR because when i play HLS/DASH live streams that has larger Playback window eg: 1hr, the stream plays from 0ms rather than playing live which always made to make me fastforward to live. This PR fixes this