feature: remove @return void from magic methods#7678
Closed
parijke wants to merge 2 commits intorectorphp:mainfrom
Closed
feature: remove @return void from magic methods#7678parijke wants to merge 2 commits intorectorphp:mainfrom
parijke wants to merge 2 commits intorectorphp:mainfrom
Conversation
parijke
changed the title
parijke
changed the title
Member
|
The rule purpose is only remove For removing |
Member
|
Add another rule under rules/DeadCode/Rector/ClasaMethod, add test under rules-tests/DeadCode/Rector/ClassMethod as well |
Member
|
@parijke Any update on this? I'd like to merge and ship it |
Member
|
No need, just new rule under DeadCode\Recror\ClassMethod is fine imo :) |
parijke
force-pushed
the
feature/remove-void-from-magic-methods-as-return
branch
2 times, most recently
from
010b7b5 to
4b9d483
Compare
samsonasik
reviewed
Dec 26, 2025
...DeadCode/Rector/ClassMethod/RemoveUselessReturnTagRector/Fixture/remove_return_construct.php
Outdated
Show resolved
Hide resolved
parijke
force-pushed
the
feature/remove-void-from-magic-methods-as-return
branch
6 times, most recently
from
aee360a to
22bee06
Compare
parijke
force-pushed
the
feature/remove-void-from-magic-methods-as-return
branch
from
22bee06 to
cfd2280
Compare
parijke
force-pushed
the
feature/remove-void-from-magic-methods-as-return
branch
from
603e154 to
44ffdb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removed the dead code from magic methods.