[NodeVisitor] Avoid reflection lookup when there is no Closure/ArrowFunction in Arg value in ClosureWithVariadicParametersNodeVisitor#7756
Closed
samsonasik wants to merge 1 commit intomainfrom
Closed
Conversation
…unction in Arg value
samsonasik
changed the title
Member
Author
|
@TomasVotruba ready 👍 |
| return null; | ||
| } | ||
|
|
||
| $methodReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($node); |
Member
There was a problem hiding this comment.
The optimization should happen inside this method.
Otherwise the performance is reduced when it's called from different place.
Member
Author
There was a problem hiding this comment.
The purpose of this PR is to avoid reflection lookup when possible on every call like, since the attribute flag filling is only when argument is closure/arrow function.
The method is general method that used in various places and imo already optimized.
Member
|
I'd prefer to keep original, as doing the same job and more readable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to avoid expensive calls when Closure/ArrowFunction is never used in function like arguments, with filter if no closure/arrowfunction in the args first.