[DeadCode] Skip trait on RemoveAlwaysTrueIfConditionRector

[samsonasik]

Fixes rectorphp/rector#9530

it seems unreliable detect true bool type on trait.

[samsonasik]

Fixed 🎉 /cc @calebdw

[samsonasik]

@TomasVotruba ready 👍

[calebdw]

Thanks for looking into this, but skipping traits indiscriminately doesn't seem like the correct approach...

Maybe this is a bug in phpstan? What does it think the type is?

[samsonasik]

PHPStan seems requires context that the trait used under some class so it can show the type used

https://phpstan.org/r/602e0b7d-009e-43f1-9a86-2be3d0e272f6

without the class that use it, it will show: Trait HasEvents is used zero times and is not analysed., that's seems how it unreliable as detected as true type.

[calebdw]

without the class that use it, it will show: Trait HasEvents is used zero times and is not analysed., that's seems how it unreliable as detected as true type.

The trait is used in my project and phpstan does analyze it.
Phpstan is dumping the type as class-string|null...

Preventing this rule from running in all traits is going to make this rule much less useful

[samsonasik]

This may requires set traitReflection as well at

rector-src/src/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php

Line 718 in 2e1e9cc

$this->privatesAccessor->setPrivateProperty($traitContext, 'classReflection', $traitClassReflection);

but that will cause other tests errors, feel free to create alternative PR :)

[TomasVotruba]

@samsonasik Looks good, thank you 👍