[dx] Rename DeprecatedAnnotationToDeprecatedAttributeRector for PHP 8.5 to explicit ConstAndTraitDeprecatedAttributeRector to make class names unique#7823
Merged
TomasVotruba merged 1 commit intomainfrom Jan 14, 2026
Conversation
TomasVotruba
changed the title
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-unique-name
branch
from
265edf7 to
5c93cee
Compare
samsonasik
reviewed
Jan 14, 2026
rules/Php85/Rector/Const_/ClassConstDeprecatedAttributeRector.php
Outdated
Show resolved
Hide resolved
Member
Author
|
PHP 8.5 also introduces same for traits - https://wiki.php.net/rfc/deprecated_traits, added |
TomasVotruba
changed the title
….5 to explicit ConstAndTraitDeprecatedAttributeRector, add trait suport
TomasVotruba
force-pushed
the
tv-unique-name
branch
from
5c93cee to
d8a35d8
Compare
Member
|
Test need to be updated to use |
Member
Author
|
This verison is now pushed on |
Member
Member
Author
|
Awesome, thanks 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proper fix for rectorphp/getrector-com#3531
Rector short class names must be unique, so there is no ambiguity while using them in config or in the docs.
I've added CI script to make sure we won't miss it again :)