Skip to content

fix(open graph images): added full url, file extension, and switch from query params to paths #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jderochervlk merged 17 commits into from
Feb 7, 2026
Merged

fix(open graph images): added full url, file extension, and switch from query params to paths #1191

jderochervlk merged 17 commits into from
Feb 7, 2026

Conversation

@jderochervlk
Copy link
Collaborator

@jderochervlk jderochervlk commented Feb 7, 2026 •
edited
Loading

It turns out that og images are finicky. After testing on several platforms I realized my first attempt wasn't correct.

  • OG images need to have a file extension
  • Some platforms (bluesky and text messages) ignore query params
  • The base URL needs to be included on some platforms

@jderochervlk jderochervlk changed the title fix: add full url to open graph images fix: add full url and file extension to open graph images Feb 7, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 7, 2026 •
edited
Loading

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8152622
Status: ✅  Deploy successful!
Preview URL: https://f286609d.rescript-lang.pages.dev
Branch Preview URL: https://vlk-fix-image-url.rescript-lang.pages.dev

View logs

@jderochervlk
Copy link
Collaborator Author

jderochervlk commented Feb 7, 2026

Tested on what's app
Screenshot_20260206-205058.png

@jderochervlk jderochervlk changed the title fix: add full url and file extension to open graph images fix(open graph images): added full url, file extension, and switch from query params to paths Feb 7, 2026
@jderochervlk
Copy link
Collaborator Author

jderochervlk commented Feb 7, 2026

Bluesky

Screenshot_20260206-220156.png

@jderochervlk
Copy link
Collaborator Author

jderochervlk commented Feb 7, 2026

Text message.

Screenshot_20260206-220132.png

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Cloudflare deployment

Deployement ID: 397aad3d-ddf5-4ba0-8a1b-79b80228fff3
Deployment Environment: preview

⛅️ wrangler 4.63.0
───────────────────
✨ Compiled Worker successfully
Uploading... (7221/7223)
Uploading... (7222/7223)
Uploading... (7223/7223)
✨ Success! Uploaded 2 files (7221 already uploaded) (1.70 sec)

✨ Uploading _redirects
✨ Uploading Functions bundle
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://397aad3d.rescript-lang.pages.dev
✨ Deployment alias URL: https://vlk-fix-full-image-url.rescript-lang.pages.dev

@jderochervlk
Copy link
Collaborator Author

jderochervlk commented Feb 7, 2026

Tested on X
Screenshot_20260206-222547.png

@jderochervlk jderochervlk marked this pull request as ready for review February 7, 2026 03:26
@jderochervlk jderochervlk enabled auto-merge (squash) February 7, 2026 03:26
@jderochervlk jderochervlk merged commit a3ac8ed into master Feb 7, 2026
3 checks passed
@jderochervlk jderochervlk deleted the vlk/fix-full-image-url branch February 7, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhammerschmidt fhammerschmidt fhammerschmidt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jderochervlk @fhammerschmidt