Conversation
cknitt
commented
Apr 27, 2025
cknitt
commented
Apr 28, 2025
Member
|
Makes me wonder if we should not bite the bullet and move PRs like rescript-lang/rescript#7402 are a good example that the current setup isn't ideal. |
Member
Author
Eventually we need to do this, yes. Not sure if I'd still like to include that in 12.0 though. In any case, we need a version with React 19 support first that still works with ReScript 11, too. |
`use(context)` seems to exactly replicate the `useContext(context)` logic, and we want to maximize retro-compability (ie. not switch from `useContext` to `use` for that under the hood). simply adding `usePromise(promise)` seems to be the simplest, least invasive way to add the functionality.
Collaborator
|
I tested examples from react 19 blog post on a project:
and everything works well, so for me it's ok! 👍 |
this **kinda** goes against the zero-cost philosophy, but I don't see a world where users would not have to reimplement those.
Freddy03h
approved these changes
May 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130