chore(rivetkit): migrate to sqlite instance per-actor for concurrency optimizations#4264
Conversation
|
🚅 Deployed to the rivet-pr-4264 environment in rivet-frontend
|
PR Review: chore(rivetkit): migrate to sqlite instance per-actor for concurrency optimizations
The core approach is sound. wa-sqlite's async build genuinely cannot be used re-entrantly on a single module instance, and scoping A few things worth tracking as follow-up: Bug: SQL injection in test fixtureIn insertValue: async (c, value: string) => {
await c.db.execute(
`INSERT INTO lifecycle_data (value, created_at) VALUES ('${value}', ${Date.now()})`,
);
},Even in a test fixture this establishes a bad pattern. Use a parameterized query form if the API supports it. Resource concern:
|
d5b839a to
b2b8dc8
Compare
7cd1a57 to
1d942b7
Compare
1d942b7 to
c9b9161
Compare
b2b8dc8 to
017b2a7
Compare
b2b8dc8 to
4472768
Compare
1d942b7 to
06dd74e
Compare
4472768 to
bc22452
Compare
06dd74e to
04ca7d0
Compare
04ca7d0 to
d56e384
Compare
bc22452 to
b383455
Compare
b383455 to
4472768
Compare
d56e384 to
06dd74e
Compare
4472768 to
994ed2a
Compare
cb21b0b to
8d71a19
Compare
994ed2a to
50a5e67
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: