Open
Conversation
rtfpessoa
reviewed
Jul 5, 2024
Owner
rtfpessoa
left a comment
There was a problem hiding this comment.
Overall looks good to me.
Before we can merge this there are a couple of things that need to be fixed:
- As this changes the templates we need to release a new major version so you need to at least have
breaking:in one of the commits for the version to be bumped - Test should be passing and we should add a couple of cases with the folding
- Remove yarn.lock as we now use package-lock.json with npm and fix conflicts
- Remove debugger statement
- Update the readme with docs
Thanks a lot for your contribution, this is a great PR and lot's of people have requested this previously, so I think it will be loved.
Let me know if you need help with anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated css for diff2html line folding..