Closed
Conversation
The palm_civet dependency has not seen any releases for a long time. Given its small complexity, this commit inlines it into the cloud_controller codebase to reduce external dependencies. Changes: - Added lib/cloud_controller/palm_civet.rb with the inlined implementation - Added spec/unit/lib/cloud_controller/palm_civet_spec.rb with all tests - Updated ByteConverter to use the inlined VCAP::CloudController::PalmCivet - Removed palm_civet gem from Gemfile Fixes #1
Owner
Author
|
Closing in favour of: cloudfoundry#4827 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR inlines the
palm_civetgem into the cloud_controller codebase to eliminate an external dependency that hasn't been updated in several years.Changes
lib/cloud_controller/palm_civet.rb- Inlined implementation of the palm_civet byte conversion utilitiesspec/unit/lib/cloud_controller/palm_civet_spec.rb- Complete test suite from the original gemlib/cloud_controller/app_manifest/byte_converter.rb- Changed require from'palm_civet'to'cloud_controller/palm_civet'palm_civetgem from GemfileImplementation Details
The inlined code is wrapped in the
VCAP::CloudController::PalmCivetmodule to maintain proper namespacing and avoid conflicts. The implementation includes:byte_size- Converts bytes to human-readable formatto_bytes- Parses human-readable byte strings to integer bytesto_megabytes- Parses human-readable byte strings to megabytesInvalidByteQuantityErrorexception classAll original functionality and tests have been preserved.
Testing
The complete test suite from the palm_civet gem has been integrated and should pass in CI. The tests cover:
Fixes #1