Explicitly define behavior of empty tls_options#291
Open
mkozono wants to merge 1 commit intoruby-ldap:masterfrom
Open
Explicitly define behavior of empty tls_options#291mkozono wants to merge 1 commit intoruby-ldap:masterfrom
tls_options#291mkozono wants to merge 1 commit intoruby-ldap:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to add these tests since this behavior may be unexpected, in particular for users of the omniauth-ldap gem https://github.com/intridea/omniauth-ldap/blob/master/lib/omniauth-ldap/adaptor.rb#L93).
Additionally, if this behavior changes (for example, by removing
unless tls_options.empty?https://github.com/ruby-ldap/ruby-net-ldap/pull/161/files#diff-8f385efd0cd6c068dec9c5db605a4d36R51), these tests would fail, and therefore help to ensure that the breaking change is deliberate.Thanks!