Fix unknow pdu Error and show the Ber class#352
Open
ggalancs wants to merge 5 commits intoruby-ldap:masterfrom
Open
Fix unknow pdu Error and show the Ber class#352ggalancs wants to merge 5 commits intoruby-ldap:masterfrom
ggalancs wants to merge 5 commits intoruby-ldap:masterfrom
Conversation
mddelk
reviewed
Mar 30, 2020
lib/net/ldap/pdu.rb
Outdated
| def initialize(ber_object) | ||
| begin | ||
| @message_id = ber_object[0].to_i | ||
| id = ber_object[0] |
Contributor
There was a problem hiding this comment.
what's the point of this 2 line change?
Author
There was a problem hiding this comment.
No one, sorry, I try to understand the ber object and I forgot that lines
| def initialize(ber_object) | ||
| begin | ||
| @message_id = ber_object[0].to_i | ||
| @message_id = ber_object[0] |
Member
There was a problem hiding this comment.
What's the benefit of removing this coercion?
Contributor
There was a problem hiding this comment.
@HarlemSquirrel Believe this was to prevent a few casting issues when the item could not be converted into an integer. Run into a few of these myself when testing.
| module Net | ||
| class LDAP | ||
| VERSION = "0.16.2" | ||
| VERSION = "0.16.2.3" |
Member
There was a problem hiding this comment.
Why change the version here?
HarlemSquirrel
requested changes
Jul 2, 2020
Member
HarlemSquirrel
left a comment
HarlemSquirrel
left a comment
There was a problem hiding this comment.
Please update this from the latest master. I've got a couple of questions as well. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.