5152 update requests export with inactive items#5211
Open
bsbonus wants to merge 6 commits intorubyforgood:mainfrom
Open
5152 update requests export with inactive items#5211bsbonus wants to merge 6 commits intorubyforgood:mainfrom
bsbonus wants to merge 6 commits intorubyforgood:mainfrom
Conversation
…nt for initialization
Collaborator
|
passes functional test |
dorner
requested changes
May 30, 2025
| # Include inactive items or items that are otherwise not in any item_requests | ||
| @organization_items.each do |item| | ||
| if item_names.exclude?(item.name) | ||
| item_names << item.name |
Collaborator
There was a problem hiding this comment.
Can item_names be a set instead of an array? Then this is automatically handled.
Collaborator
|
Also tests seem to be failing. |
Contributor
Author
Collaborator
|
Looks like this has some feedback; I think if anyone else would like to take a look at completing it then that would be welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
X I have performed a self-review of my own code,
X I have commented my code, particularly in hard-to-understand areas,
X I have made corresponding changes to the documentation,
X I have added tests that prove my fix is effective or that my feature works,
X New and existing unit tests pass locally with my changes ("bundle exec rake"),
X Title include "WIP" if work is in progress.
X I acknowledge that I will not force push my branch once reviews have started.
Resolves #5152 partially
Description
Updates the "requests" export to include inactive items in the columns.
Type of change
How Has This Been Tested?
Screenshots
requests_before_fix.csv
requests_after_fix.csv