Allow a hard limit on number of specific items per request#5386
Allow a hard limit on number of specific items per request#5386
Conversation
| tabindex="-1" | ||
| data-bs-backdrop="static" | ||
| data-confirmation-target="modal"> | ||
| </div> |
There was a problem hiding this comment.
just added a missing div in this file, rest of the changes are just spacing from auto-format
| data-confirmation-pre-check-path-value="<%= validate_partners_requests_path(format: :json) %>"> | ||
| <div class="card-body"> | ||
|
|
||
| <% if @errors.present? %> |
There was a problem hiding this comment.
removed this error message in favor of flash messages instead
| item_ids = item_requests.map(&:item_id) | ||
| if item_ids.uniq.length != item_ids.length | ||
| errors.add(:item_requests, "should have unique item_ids") | ||
| errors.add(:base, "Please ensure a single unit is selected for each item that supports it") |
There was a problem hiding this comment.
changed to :base since we are printing from the error.full_messages now so that it won't include the ugly and confusing item_requests before the error message
| .joins(profile: :counties) | ||
| .group(:id) | ||
| .pluck(Arel.sql("partners.id, STRING_AGG(counties.name, '; ' ORDER BY counties.region, counties.name) AS county_list")) | ||
| .pluck(Arel.sql("partners.id, STRING_AGG(counties.name, '; ' ORDER BY LOWER(counties.region), LOWER(counties.name)) AS county_list")) |
There was a problem hiding this comment.
have no idea why this started failing in this PR but if a region or name is lower case and another is uppercase of the same letter the uppercase will take precedence in the order
| pre_existing_entry = items[input_item['item_id']] | ||
|
|
||
| if pre_existing_entry | ||
| if pre_existing_entry.request_unit != input_item['request_unit'] |
There was a problem hiding this comment.
removed this because we basically add the same error in the model
2 participants
Resolves #5269
Description
request_limittoItemUnitandunit_request_limittoItemfields to models"[Item name]: You requested [amount requested] [units if applicable], but are limited to [request limit] [units if applicable].
Type of change
How Has This Been Tested?
Screenshots
items/:id/editpage/partners/requestspageremoved this error message from
/partners/requestspage