Add feature flags system with beacons flag for targeted rollout#589
Open
dmitrytrager wants to merge 3 commits intomainfrom
Open
Add feature flags system with beacons flag for targeted rollout#589dmitrytrager wants to merge 3 commits intomainfrom
dmitrytrager wants to merge 3 commits intomainfrom
Conversation
Credentials-based feature flags adapted from Rails 8.2 pattern for 8.1, using Rails.application.credentials.dig instead of Rails.app.creds.option. Supports per-user targeting via allowed_emails, ENV overrides, and request-scoped toggles for testing. Beacons feature gated to admin@skillrx.org. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
… spec Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dmitrytrager
commented
Feb 4, 2026
| @@ -0,0 +1,62 @@ | |||
| module FeatureFlags | |||
Collaborator
Author
There was a problem hiding this comment.
We may want to move it to services
| module FeatureFlags | ||
| extend self | ||
|
|
||
| def enabled?(flag_name, user: nil) |
Collaborator
Author
There was a problem hiding this comment.
Can use overrides, env vars and setup from creadentials
| def user_allowed?(config, user) | ||
| return false if user.nil? | ||
|
|
||
| allowed_emails = config[:allowed_emails] |
Collaborator
Author
There was a problem hiding this comment.
We may want to identify users in a different way later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credentials-based feature flags adapted from Rails 8.2 pattern for 8.1, using Rails.application.credentials.dig instead of Rails.app.creds.option. Supports per-user targeting via allowed_emails, ENV overrides, and request-scoped toggles for testing. Beacons feature gated to admin@skillrx.org.
What Issue Does This PR Cover, If Any?
Resolves #587
What Changed? And Why Did It Change?
I borrow this approach from article: https://codewithrails.com/blog/rails-feature-flags-credentials/
It can work for us since it is dependency-free
How Has This Been Tested?
Please Provide Screenshots
Additional Comments