[RFC] Implement new feature: Custom messages#166
Open
saulvaldelvira wants to merge 2 commits intorust-cli:masterfrom
Open
[RFC] Implement new feature: Custom messages#166saulvaldelvira wants to merge 2 commits intorust-cli:masterfrom
saulvaldelvira wants to merge 2 commits intorust-cli:masterfrom
Conversation
The email lacks a closing '>'
Make setup_panic accept a function as a parameter, that will be called to write the message. This function receives a Write reference, an optional Path and the Metadata. If no function is provided, use the original function "write_msg"
Collaborator
|
In our contributing documentation, we ask for problems and solutions to be worked out in issues and to leave PRs for code review. |
Author
Hello! Sorry for that. |
Collaborator
|
You could post you use case and idea to #54, it seems related enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to provide a custom function to write the message.
I've also fixed a small typo in one of the tests.
I haven't added any documentation yet. If the maintainers like the idea, I'll gladly document this.
Related issue: #54