Set and enforce an msrv of 1.64.0#110
Merged
akern40 merged 1 commit intorust-ndarray:masterfrom Nov 9, 2025
Merged
Conversation
This crate had an MSRV of 1.64 that was enforced in the CI; however, this was done by way of an explicit pin. Now that Rust comes with an MSRV-aware resolver, we set the `rust-version` explicitly and add a `Cargo.lock` that represents the dependencies needed to support that. We also add a weekly CI job to ensure that the MSRV still works.
Contributor
Author
|
@nilgoyette this should fix the CI issues we're seeing in #109, then we can merge that and make a release |
nilgoyette
approved these changes
Nov 9, 2025
Contributor
nilgoyette
left a comment
nilgoyette
left a comment
There was a problem hiding this comment.
I don't know much about github workflows, but what I read doesn't seem too bad. I prefer being honest and tell you that, if you need an actual serious review, it's best to ask someone else.
Contributor
Author
|
Appreciate it! I'm more just tagging for your awareness - this whole technique is copied from Which raises a question: do you want me to tag you on stuff like this? No worries if not, I just want to make sure you aren't getting noise you don't want |
Contributor
No problem, you can tag me on any Rust PR. I'll do what I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This crate had an MSRV of 1.64 that was enforced in the CI; however, this was done by way of an explicit pin. Now that Rust comes with an MSRV-aware resolver, we set the
rust-versionexplicitly and add aCargo.lockthat represents the dependencies needed to support that.We also add a weekly CI job to ensure that the MSRV still works.