Fix four bugs in plot_template_data.py causing compute_oracle and pipeline to fail#90
Draft
Fix four bugs in plot_template_data.py causing compute_oracle and pipeline to fail#90
Conversation
Co-authored-by: xadupre <22452781+xadupre@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on add datasets teaching PR
Fix four bugs in plot_template_data.py causing compute_oracle and pipeline to fail
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plot_template_data.pyhad multiple bugs that collectively caused the entire script to fail silently or with errors — the most subtle being thatselect_variables_and_cleanreturned an empty table, making all downstream logic operate on no data.Bugs fixed
select_variables_and_clean(root cause):groupby(keys).count()replaced real effectif values with row counts. Since"Session"is part of the key, every(Session, formation)combo is unique — sogroups[cible] > 1always produced an empty DataFrame. Replaced withduplicated(subset=keys, keep=False)+ inversion to keep only rows with a unique key combination while preserving actual values:compute_oracle:.dropna(axis=0)was commented out as# fails, but it is required — without it the pivot table retains NaN for formations present in only one year, causingmean_absolute_errorto raiseValueError. Uncommented it.split_train_test: Parameter typocuble→cible, and test-set rows usedtrain_testmask instead of~train_test.make_pipeline:c != "cible"(string literal) →c != cible(variable), so the target column is correctly excluded from the feature list.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.